cakephp / elastic-search

Elastic search datasource for CakePHP
Other
88 stars 53 forks source link

BeforeFind event not triggered #258

Closed zunnu closed 1 year ago

zunnu commented 3 years ago

Im using Elasticsearch 6 with version 2 of this plugin. The beforefind event is not triggered. In my index I have.

public function beforeSave($event, $product, $options) {
    // triggered
}

public function beforeFind($event, $product, $options) {
    // not triggered
}

I looked at the code a bit and in the execute function there is event call for beforeFind. Should there be or am I missing something? https://github.com/cakephp/elastic-search/blob/2.x/src/Query.php#L558

github-actions[bot] commented 3 years ago

This issue is stale because it has been open for 120 days with no activity. Remove the stale label or comment or this will be closed in 15 days

markstory commented 3 years ago

Looks like while we have beforeFind in the API docs we never actually implemented it.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 120 days with no activity. Remove the stale label or comment or this will be closed in 15 days