search

cakephp / elastic-search

Elastic search datasource for CakePHP
Other
88 stars 53 forks source link

Override abstract methods alias/hasField in Type.php #31

Closed damianoporta closed 9 years ago

damianoporta commented 9 years ago 
Error: Class Cake\ElasticSearch\Type contains 2 abstract methods and must therefore be declared abstract or implement the remaining methods (Cake\Datasource\RepositoryInterface::alias, Cake\Datasource\RepositoryInterface::hasField) 
File /home/vagrant/Apps/app.local/vendor/cakephp/elastic-search/src/Type.php 
Line: 655
damianoporta commented 9 years ago

something about:

    public function alias($alias = null)
    {
        return $this->name($alias);
    }

    public function hasField($field)
    {
        $schema = $this->schema();
        return $schema->field($field) !== null;
    }

Can I send a PR ?

markstory commented 9 years ago

Those methods are already sitting in a pull request - #29

damianoporta commented 9 years ago

@markstory oh I see. Please merge :)