search

cakephp / elastic-search

Elastic search datasource for CakePHP
Other
88 stars 53 forks source link

Fix CS errors and a couple typos #40

Closed bcrowe closed 9 years ago

bcrowe commented 9 years ago

Follows https://github.com/cakephp/elastic-search/pull/39

A couple param/return descriptions are a little generic. Feel free to elaborate.

The remaining errors are protected methods lacking an underscore prefix and the FilterBuilder and_() & or_() methods not being camel cased. Should we just adjust the protected methods to follow suit for the time being, and update when/if drop that convention as a whole?

markstory commented 9 years ago

Nice work @bcrowe!

As for the protected methods, where possible (like in new plugins) I think it makes sense to adopt the more broadly accepted standard of not prefixing protected methods with _.

bcrowe commented 9 years ago

Do we want to add a branch to Cake's code sniffer that excludes the underscore prefix and pin the dev-branch to this plugin?