search

cakephp / elastic-search

Elastic search datasource for CakePHP
Other
88 stars 53 forks source link

Elastic 2 #88

Closed gaetansnl closed 8 years ago

gaetansnl commented 8 years ago

I'm not sure what we should do for the ->query method. We can't predict what the user will pass and we need a bool query for simple filter.

And I'm not sure why there isn't options anymore on regex query on elastica. In the doc there is flags https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-regexp-query.html.

I've also temporarily addedan index refresh in delete tests. https://www.elastic.co/guide/en/elasticsearch/plugins/2.0/delete-by-query-plugin-reason.html . Seems to be needed now

lorenzo commented 8 years ago

@pulse14 thanks a lot for doing this... All these changes are worth of creating a new branch and target a 1.0 release... let me create that branch.

Do you mind if I close the PR and you reopen it targeting 1.0?

gaetansnl commented 8 years ago

Ok @lorenzo

lorenzo commented 8 years ago

The branch is there now