search

cakephp / localized

I18n and L10n related CakePHP code
Other
213 stars 179 forks source link

Finnish validations #116

Closed makallio85 closed 8 years ago

makallio85 commented 8 years ago

Is there something that still needs to be done?

josegonzalez commented 8 years ago

@makallio85 do you mind commenting at least on the phone format? Throwing an exception in an official library feels bad :(

josegonzalez commented 8 years ago

Also sorry for not commenting sooner!

makallio85 commented 8 years ago

I actually cant say nothing about finnish phone format, of course landline is quite easy, but cellulars... there are just so many possible prefixes and actually i dont even know the max/min lenght.

So i just comment exception away?

makallio85 commented 8 years ago

And actually, I was just following, how this was used be done by others https://github.com/cakephp/localized/tree/master/src/Validation

Quite much exceptions there also.

antograssiot commented 8 years ago

yeah @josegonzalez it is already implemented like that in other language. I see this as an incremental improvement so I'm ok with this changes. :+1: