Found serious bug in fi ssec validator

cakephp / localized

I18n and L10n related CakePHP code

Other

213 stars 179 forks source link

Found serious bug in fi ssec validator #122

Closed makallio85 closed 8 years ago

dereuromark commented 8 years ago

Wouldnt 3rd arg of "true" for in_array solve this? If this is a serious bug, please also add a few regression tests here.

makallio85 commented 8 years ago

Thats true, some how I wasnt aware of in_array param. Added also new ssec that was failing before.

dereuromark commented 8 years ago

Thanks for the quick fix, in general in cakephp code we should never use in_array() without proper strictness, it is usually always a trap for false positives around 0 integer value input etc.

dereuromark commented 8 years ago

Looks good to me :+1: