search

cakephp / localized

I18n and L10n related CakePHP code
Other
213 stars 179 forks source link

[question] Update template? #127

Closed elboletaire closed 8 years ago

elboletaire commented 8 years ago

Should we update the cake.pot template when we commit translation updates? Or maybe it should be updated in a separate issue/PR?

I've recently created #125 and #126 and I'm not sure if I should update the template too.

In fact, maybe we could remove it, don't we?

elboletaire commented 8 years ago

BTW, to update those translations I've created my custom cake.pot template from version 3.2.8. I'm not sure if that's the best way to do it :confused:

elboletaire commented 8 years ago

Helloooooo

dereuromark commented 8 years ago

Either we keep it updated or we remove it yeah I think updating those along with it should be fine though.

elboletaire commented 8 years ago

I think that it's a better idea to remove it and let people generate it when they wanna update the cake.pot translations in their language.

Updating it manually is a pain. I see a lot of PR just for updating this file, which is not ideal.

Auto-updating it would be very nice, but I guess you won't add the i18n extraction to the travis builds :sweat_smile:

elboletaire commented 8 years ago

Cuckoo!

dereuromark commented 8 years ago

I am not sure. Keeping it around shouldn't hurt. But I dont mind either way. If we remove it we should definitly put in the readme/docs on how to generate it.

elboletaire commented 8 years ago

Thanks @dereuromark I'll try to do that then :)

125 and #126 can be merged now. I'll do another PR with the template removal + adding information to the readme.