search

cakephp / localized

I18n and L10n related CakePHP code
Other
213 stars 179 forks source link

- phone numbers in Canada are of the same format as those in the USA.… #146

Open jazty opened 7 years ago

jazty commented 7 years ago

… No need to throw NotImplemented. Copied the US phone validation rules to Canada.

dereuromark commented 7 years ago

Can we have some tests for this please?

jazty commented 7 years ago

Copied the tests as well and they all pass.

dereuromark commented 7 years ago

Thx, looks good to me 👍

dereuromark commented 7 years ago

@jazty Still interested in getting this finished up and merged?

othercorey commented 4 years ago

Should we trim and merge or close this?

dereuromark commented 1 year ago

If we can trim and merge, that would probably be best. Just closing is easiest, but then nothing is gained.