search

cakephp / localized

I18n and L10n related CakePHP code
Other
213 stars 179 forks source link

[GB] Optional postcode space #150

Closed davidyell closed 7 years ago

davidyell commented 7 years ago

Make the space between the two parts of the postcode optional. Most developers normalize the postcode by removing the space, which causes this validation rule to fail.

Although I would prefer to allow both lowercase and uppercase, a call to strtoupper() isn't a big deal.

dereuromark commented 7 years ago

Sounds good to me.

davidyell commented 7 years ago

Ooh, I seem to have tripped up the validation rule with my new test cases. I'll take a look at updating it.

Any thoughts on allowing both upper and lower case letters? Would be a trivial change. I noticed it's /i 😉

dereuromark commented 7 years ago

It already allows afaik: /i means CI.

davidyell commented 7 years ago

Thanks for the merge @dereuromark 👍