search

cakephp / localized

I18n and L10n related CakePHP code
Other
213 stars 177 forks source link

Deprecate the invalid personId() method for Poland. #180

Closed robertpustulka closed 6 years ago

robertpustulka commented 6 years ago

NIP is not a polish social security number nor a person ID. It's a number given to companies that pay taxes (historically it was also given to natural persons but currently PESEL is sufficient). It's closest equivalent is a VAT identification number.

Actual Polish security/person ID is PESEL.

I deprecated the incorrect method and added nip() method for NIP validation. In the future this method behavior can be changed to validate PESEL numbers.

Refs https://github.com/cakephp/localized/pull/178#discussion_r152950534

robertpustulka commented 6 years ago

@dereuromark Should this change be tagged as 3.3.0 since it adds a new method and a deprecation?