search

cakephp / localized

I18n and L10n related CakePHP code
Other
213 stars 177 forks source link

add fr phone validation + test, follow #87 #91

Closed cake17 closed 9 years ago

cake17 commented 9 years ago

Hope this works this time.

antograssiot commented 9 years ago

@cake17 Indentation seems to be off in https://travis-ci.org/cakephp/localized/jobs/41948611 tabs must be used instead of spaces.

Let me know if you need help

cake17 commented 9 years ago

Thanks ! I think this time it will pass ! I just changed my editor, and it puts spaces instead of tabs !! :-( Miracle ! :)

dereuromark commented 9 years ago

Looks good now.

@antograssiot I would like to release a new tagged version 2.4.0. then after this all got merged in. What do you think? Already prepared some of the release notes (see tags admin area).

We should also then start migration to 3.0 to have localized validation available for the first RC release then.

antograssiot commented 9 years ago

@dereuromark Yes we can merge this one and close #87 as this one seems. I will add this modification the release notes.

Regarding 3.0, I too think we should start, I'm ok to do ll the work for the french locale and for sure @cake17 will be abble to verify/help. Do you wan't to organize the new branch ?

antograssiot commented 9 years ago

nice work @cake17 and @Back-Sephiroth