migration --fake command not working

cakephp / phinx

PHP Database Migrations for Everyone

https://phinx.org

MIT License

4.46k stars 892 forks source link

migration --fake command not working #2229

Closed demmmmios closed 8 months ago

demmmmios commented 11 months ago

Hi i found out that after update to new version --fake option for migration command is not working. The issue is here https://github.com/cakephp/phinx/commit/eccc64b53e585608da8ac073a2a4728447e6d98b because it was moved from fake condition. Is this intended or bug?

MasterOdin commented 10 months ago

Yup, definitely a bug, I think can narrow the if (!$fake) check to be just around running the migration, fine to do the transaction stuff regardless if we're running the migration or just inserting a log of it. Will need to think about writing up a test for this so we can catch this sort of regression. Thanks for reporting it.

dereuromark commented 8 months ago

@demmmmios Do you want to make a PR here? We can fast track the merge and release here.