search

cakephp / phinx

PHP Database Migrations for Everyone
https://phinx.org
MIT License
4.46k stars 892 forks source link

:recycle: default to null for type of column in addColumn #2236

Closed gaydamakha closed 10 months ago

gaydamakha commented 10 months ago

As accepting null for $type parameter was rollbacked in #2224, I think it is more consistent to default to null value after its removal in #2218. Passing Column object in first argument makes the $type parameter useless. So, the PR simplifies a bit the adding of a new column (modified in the unit test).

othercorey commented 10 months ago

Leave this up to @ndm2

ndm2 commented 10 months ago

Makes sense to me, no need to force passing a value that isn't going to be used.