search

cakephp / phinx

PHP Database Migrations for Everyone
https://phinx.org
MIT License
4.46k stars 892 forks source link

Loosen psr/container version constraint #2237

Closed MasterOdin closed 10 months ago

MasterOdin commented 10 months ago

Closes #2227

cakephp/cakephp@5.0.2 loosened their version constraint of psr/container when then allows us to loosen it as well, allowing both ^1.1 or ^2.0 to be used based on other things you might install alongside phinx.

MasterOdin commented 10 months ago

@dereuromark This should not have been merged yet since one of the CI checks is failing from this change. I'm also not sure how best to resolve this, where composer update --prefer-lowest won't install psr/container@^1.1 as it doesn't install the lowest version of transitive dependencies, and one of the transitive dependencies ends up with psr/container@^2.0. This causes dereuromark/composer-prefer-lowest tool to fail.

I suppose a "fix" would be to install the lowest version of a transitive dependency as a devDependency within phinx (at least in the CI check), but that's certainly hacky.

dereuromark commented 10 months ago

composer is sometimes a bit stupid https://github.com/cakephp/phinx/commit/62fda40e1870f2896a91130f6b0c9658f18a332d should make it green again