search

cakephp / phinx

PHP Database Migrations for Everyone
https://phinx.org
MIT License
4.46k stars 892 forks source link

Use UUID_BLOB for binary16 #2243

Closed dereuromark closed 10 months ago

dereuromark commented 10 months ago

Follow https://github.com/cakephp/phinx/pull/2239

Also needs https://github.com/cakephp/cakephp/pull/17421

dereuromark commented 10 months ago

Yes, we need to wait for the core PR to match approval status. Also, I needed 

str_contains(strtolower($column), 'blob')

since the column usually comes in uppercase

but actually 

if (($col === 'binary' && $length === 16) || strtolower($column) === 'uuid_blob')

should suffice