cakephp / phinx

PHP Database Migrations for Everyone
https://phinx.org
MIT License
4.45k stars 895 forks source link

Fixing errors when migration name is null #2268

Closed jaydiablo closed 5 months ago

jaydiablo commented 5 months ago

Upgraded PHP (to 8.1) and Phinx (to latest) an ran into some PHP TypeErrors when running our migrations.

We've been using Phinx for a very long time, and have some migration versions in our phinxlog that have a null migration_name since they were ran before there was a migration name column, and apparently that column is nullable.

This PR just adds a null coalescing operator in a couple of places that the TypeError was thrown. I've also added a test (based on another existing test, just with the migration_name changed to null) that did hit these TypeErrors (and don't with the code change in place).

We could just update our migrations to use an empty string, or populate the migration names, but figured this might benefit other Phinx users.