search

cakephp / phinx

PHP Database Migrations for Everyone
https://phinx.org
MIT License
4.46k stars 889 forks source link

Append sqlite suffix to name on info output #2307

Closed MasterOdin closed 2 months ago

MasterOdin commented 2 months ago

Closes #2298

PR makes it so that the database name informational output will contain the suffix for sqlite connections, e.g.:

 $ bin/phinx migrate
Phinx by CakePHP - https://phinx.org. 0.x-dev

using config file phinx.yaml
using config parser yml
using migration paths
 - /home/mpeveler/github/phinx/db/migrations
using seed paths
 - /home/mpeveler/github/phinx/db/seeds
warning no environment specified, defaulting to: testing
using adapter sqlite
using database phinx_test.sqlite3
ordering by creation time

 == 20240906173954 Foo: migrating
 == 20240906173954 Foo: migrated 0.0158s

All Done. Took 0.0184s

This should make the info more informational on what's happening. Working on this, I am definitely leaning increasingly towards deprecating/removing the suffix option altogether and require that users only use the name option instead, which is similar to how most ORMs handle it.

zeleznypa commented 1 month ago

Unfortunately it cause the https://github.com/cakephp/phinx/issues/2311