search

cakephp / twig-view

Twig View for CakePHP
MIT License
13 stars 7 forks source link

Twig's native format filter is being overwritten #55

Closed biesbjerg closed 4 years ago

biesbjerg commented 4 years ago

Twig's native format filter is being overwritten by: https://github.com/cakephp/twig-view/blob/e3e03ae99e3bc93ec481eed0a2b0cb92aac13d0b/src/Twig/Extension/NumberExtension.php#L43.

Number::format is already being made available by number_format, so maybe the other one could be removed? https://github.com/cakephp/twig-view/blob/e3e03ae99e3bc93ec481eed0a2b0cb92aac13d0b/src/Twig/Extension/NumberExtension.php#L40

ADmad commented 4 years ago

Would you like to submit a fix?

biesbjerg commented 4 years ago

Opened a PR: https://github.com/cakephp/twig-view/pull/56

othercorey commented 4 years ago

Closed in https://github.com/cakephp/twig-view/pull/56