search

cakephp / upgrade

Upgrade tools for CakePHP meant to facilitate migrating from one version of the framework to another
MIT License
110 stars 60 forks source link

`AddMethodCallArgsRector` infinitely adds more args #243

Closed LordSimal closed 1 year ago

LordSimal commented 1 year ago 
    ---------- begin diff ----------
@@ @@

             return [
                 'departure' => $departure->format('Y-m-d H:i'),
-                'arrival' => $arrival->addHours(1)
+                'arrival' => $arrival->addHours(1, 1)
                     ->format('Y-m-d H:i'),
                 'itinerary' => $faker->realText(),
                 'purpose' => $faker->realText(),
    ----------- end diff -----------

Applied rules:
 * AddMethodCallArgsRector

 [OK] 1 file has been changed by Rector
LordSimal commented 1 year ago

Well... this is kind of expected...

The chronos rules should only be applied once when converting the old methods to the new methods...