search

cakephp / upgrade

Upgrade tools for CakePHP meant to facilitate migrating from one version of the framework to another
MIT License
110 stars 60 forks source link

5.x: rector update #245

Closed LordSimal closed 1 year ago

LordSimal commented 1 year ago

findParentType() was removed in https://github.com/rectorphp/rector/releases/tag/0.17.3

But in the end this rector rule only applies to properties which requires a class to be present (as far as I can tell, I may be wrong here)

So its easier to just remove that now non-functional check instead of replacing it with something that re-implements it.

There is also the problem of the removed MethodCallToAnotherMethodCallWithArgumentsRector in

which we already talked about in https://github.com/cakephp/upgrade/pull/235

I'll try to add this here as well

markstory commented 1 year ago

Looks good to me. Sure would be nice if rector would slow down on removing features in patch releases 😓