search

caketop / python-starlark-go

🐍 Python bindings for starlark-go 🐍
https://python-starlark-go.readthedocs.io/
Apache License 2.0
20 stars 7 forks source link

Attempts to build wheels across more architectures #120

Closed colindean closed 1 year ago

colindean commented 1 year ago

Uses uvloop's configuration for inspiration/nearly direct copying.

https://github.com/MagicStack/uvloop/blob/afb326897c26f01b864f65f016a7f3f80d9db8ad/.github/workflows/release.yml#L72-L87

Fixes #119

colindean commented 1 year ago

N.b. this change is an (educated) shot in the dark.

colindean commented 1 year ago

It looks like the wheel building succeeded and what failed is that I don't have a token setup to test upload to pypi.

jordemort commented 1 year ago

I'll try and figure out how to run it with the token, I want to see how it looks on TestPyPI with the additional architectures before I merge.

colindean commented 1 year ago

Any change you'd take a look at this in the next few days?

jordemort commented 1 year ago

Thanks for the contribution!

I made a couple of tweaks:

Waiting for one more cycle of CI and then I'll merge. I've tagged this PR as a patch version bump so fresh wheels should be available on PyPI shortly thereafter.

jordemort commented 1 year ago

🚀 [bumpr] Bumped! New version:v0.1.2 Changes:v0.1.1...v0.1.2

jordemort commented 1 year ago

https://github.com/caketop/python-starlark-go/releases/tag/v0.1.2 is now available here and on PyPI.

It looks like we inadvertently dropped i686 support here; I'm going to wait and see if anyone complains about that before I worry about putting it back.

I put a release announcement on my blog: https://jordemort.dev/blog/python-starlark-go-0.1.2/

colindean commented 1 year ago

Thank you for merging and for the recognition!