search

caksoylar / keymap-drawer

Visualize keymaps that use advanced features like hold-taps and combos, with automatic parsing
https://caksoylar.github.io/keymap-drawer
MIT License
707 stars 59 forks source link

Some config options don't seem to have any effect, unclear why #38

Closed minusfive closed 1 year ago

minusfive commented 1 year ago

E.g., for Corne-ish Zen (and I imagine all cornes?) neither key_w nor split_gap seem to have any effect.

caksoylar commented 1 year ago

Those settings are only used by the ortho layout generator, see comments at https://github.com/caksoylar/keymap-drawer/blob/main/keymap_drawer/config.py#L13 (I know, they need to be documented properly 😞).

The reason is that for qmk_keyboard physical layouts the QMK info.json defines the positioning and key sizes, we only scale them in both x/y via key_h.

minusfive commented 1 year ago

Gotcha! No worries, docs are never done man. So I should be able to further customize by essentially cloning the corne_rotated layout, tweak it and pass it as a param to the command, right?

caksoylar commented 1 year ago

Yes, you can customize it as you like and then pass it with -j ...json argument. Or. if you have it next to the keymap file with name corneish_zen.json (i.e. .keymap replaced by .json) then the workflow will pick it up automatically. This was originally added to support keymap-editor which creates/uses that json.

minusfive commented 1 year ago

Or. if you have it next to the keymap file with name corneish_zen.json (i.e. .keymap replaced by .json) then the workflow will pick it up automatically.

image