search

caksoylar / keymap-drawer

Visualize keymaps that use advanced features like hold-taps and combos, with automatic parsing
https://caksoylar.github.io/keymap-drawer
MIT License
730 stars 62 forks source link

Add an artifact as destination option for using in subsequent jobs #72

Closed michaelrommel closed 9 months ago

michaelrommel commented 9 months ago

This PR adds the functionality to add in addition to a commit or as alternative an artifact where the generated svg and yaml files are stored.

The workflow outputs the artifact-id as well as let the user define the name of the artifacts zip file.

michaelrommel commented 9 months ago

I have to figure out how to squash all those commits into one before opening a PR. Sorry about that...

Oh, and all that fromJSON stuff is just because my images/ folder has more yaml files in it, so I only wanted the generated ones from keymap-drawer in the artifact, not the existing ones from the repo. So I thought it makes sense, to build an array with all generated .svg|.yaml files and give that to upload-artifact. But I did not test it with multiple keyboards, I currently have only one... 😅

caksoylar commented 9 months ago

Don't worry about the commits, I can squash while merging, unless there is multiple functionality that would be better off in separate commits. Thanks for the PR, I'll review this later today.

caksoylar commented 9 months ago

Tested at https://github.com/caksoylar/zmk-config/actions/runs/7945165830 as well, thanks!

michaelrommel commented 9 months ago

Thank you, Cem, for letting me work with you on this! I have now deleted my fork and referenced your official workflow again! Have a good weekend!