search

caksoylar / keymap-drawer

Visualize keymaps that use advanced features like hold-taps and combos, with automatic parsing
https://caksoylar.github.io/keymap-drawer
MIT License
730 stars 62 forks source link

ZMK profile numbering inconsistency #99

Closed quintuple-lained closed 5 months ago

quintuple-lained commented 5 months ago

profiles 0-4 all get incremented by 1 to be more human readable, profiles beyond this dont seem to get the same treatment, leading to two "BT 5" profiles in the graphic despite them actually being BT 4 and 5 image that shows this issue: image my repository where this issue occurs https://github.com/quintuple-lained/lained-ergonaut-keymap

caksoylar commented 5 months ago

Hi, the parser by default doesn't touch the profile numbers besides putting them in the hold field (bottom legend). The 0-4 to 1-5 mapping is because of these items in the config that override the legends: https://github.com/quintuple-lained/lained-ergonaut-keymap/blob/main/keymap-drawer/config.yaml#L23-L27 (I assume you copied this from my config 😄)

So if you remove those overrides, or add overrides for profiles 5-9, you can get consistent behavior.

quintuple-lained commented 5 months ago

im sorry for not knowing this, thank you for pointing this out

caksoylar commented 5 months ago

No worries!