search

cakturk / go-netstat

A netstat implementation written in Go
MIT License
237 stars 67 forks source link

Windows support #1

Closed PaluMacil closed 5 years ago

PaluMacil commented 6 years ago

Since the command netstat exists on Windows, it would be good to either add a help wanted to this issue so that someone like me could come along and add support. If you don't think this is in scope for this library, I could make a PR to mention that it is Linux only in the README. I am not familiar with BSD, so I don't know if that would be easy to add (or even identical to Linux), but I'd be willing to try that out too (but it might be at a much later date).

cakturk commented 5 years ago

Hello @PaluMacil

I'm sorry for the late reply. I added Windows support for the library. I would appreciate if you could test these changes and give feedback. If you find that the changes are sufficient for Windows support, you can close this issue.

As for BSD support, I think the implementation difficulty would be on a par with Windows or a little bit harder. If you plan to add support for FreeBSD, I think you can use the information below as a guide.

https://svnweb.freebsd.org/base/release/11.0.0/usr.bin/sockstat/sockstat.c?view=markup#l571

If you have any changes that you think will be useful, you can always make a PR. Contributions are always appreciated.

PaluMacil commented 5 years ago

I still need to test this but am traveling for a week, and I'm not sure if I can go much till I return, but I will try to address the Windows testing upon my return.

cakturk commented 5 years ago

Closing due to further inactivity.