Fixing ActivityLookup - Githubissues

caktus / django-timepiece

A multi-user Django application for tracking people's time on projects.

MIT License

361 stars 115 forks source link

Fixing ActivityLookup #862

Closed nmashton closed 8 years ago

nmashton commented 8 years ago

ActivityLookup had two issues:

If the user had no Project selected, then '' was passed in as the term, causing the invalid function call Project.objects.get(pk='').
In any case, even if a Project was selected, nothing in Lookup's get_query method was returning a restricted set of results.

Two things are added:

The default value for request.GET['project'] is set to None, and a guard is added to ensure that the value is non-None and non-''.
The successful return value is restricted by the search term.

daaray commented 8 years ago

Assuming Travis eventually passes, this is :100: