search

caktus / jade-truffle

The smallest Caktus
1 stars 1 forks source link

Evaluate whitenoise. #28

Open JeremyGibson opened 3 years ago

JeremyGibson commented 3 years ago

Vinod's change should have fixed this, but it looks like it's not in dev.py on our current project. Not sure why.

vkurup commented 3 years ago

Just curious why we'd want to make this change? I prefer using the same settings (as much as possible) in dev and production. This setting does cause issues in unittests, so for philly-hip, we do turn it off for tests like this:

if "pytest" in sys.modules:
    STATICFILES_STORAGE = "django.contrib.staticfiles.storage.StaticFilesStorage"

But maybe there are other problems it is causing for you as well?

JeremyGibson commented 3 years ago

I forgot about your previous commit, Colin found it. I'll change this to evaluate.