UFW State Improvements - Githubissues

caktus / margarita

A collection of delicious Salt states for Django project deployments.

BSD 3-Clause "New" or "Revised" License

34 stars 8 forks source link

UFW State Improvements #1

Open mlavin opened 11 years ago

mlavin commented 11 years ago

I threw together the ufw states and they can be much better. First they should be broken into the underlying modules and the states themselves. Also they could do a better job checking if the command is necessary before calling it. For instance we don't need to call ufw enable if ufw status already shows it is active.

dpoirier commented 9 years ago

I'm looking for ways to maybe simplify this a little:

Do we ever need to deal with UDP? Or could we just make everything assume TCP?
Do we ever need to delete a rule? Would it be enough if we could just change 'allow' to 'deny' if need be?
Do we ever need to write a state to say that ufw should not be enabled? That's the default after install anyway.