caktus / margarita

A collection of delicious Salt states for Django project deployments.
BSD 3-Clause "New" or "Revised" License
34 stars 8 forks source link

Adding `letsencrypt_domains` #144

Closed nmashton closed 8 years ago

nmashton commented 8 years ago

Often we'd like to have a letsencrypt cert for multiple domains, e.g. www.example.com as well as example.com. As currently set up, letsencrypt will certify only the canonical domain at pillar['domain'] and nothing else.

It's pretty easy to get letsencrypt to do multiple domains: you just include multiple -d arguments.

A simple way to achieve this in Margarita is to create a variable letsencrypt_domains which can be optionally specified in Pillar as a list of alternative domains (defaulting to the single-item list with the canonical domain).

dpoirier commented 8 years ago

Can we add documentation of this to the dev docs and link to that pull request from here?

nmashton commented 8 years ago

Would the documentation belong in the dev docs or in the provisioning docs of the project template?

nmashton commented 8 years ago

PR for dev docs amendment submitted.

dpoirier commented 8 years ago

:key: