Improve the Let's Encrypt certification states

caktus / margarita

A collection of delicious Salt states for Django project deployments.

BSD 3-Clause "New" or "Revised" License

34 stars 8 forks source link

Improve the Let's Encrypt certification states #149

Closed jbradberry closed 7 years ago

jbradberry commented 7 years ago

use a pip install of certbot, instead of a git checkout
clean up the old git checkout, if it is there
remove the old cron job
add a new cron job that uses the command's new name, certbot

refs #145

dpoirier commented 7 years ago

Warning at https://letsencrypt.readthedocs.io/en/latest/install.html:

Please do not use python setup.py install or python pip install .. Please do not attempt the installation commands as superuser/root and/or without virtual environment, e.g. sudo python setup.py install, sudo pip install, sudo ./venv/bin/.... These modes of operation might corrupt your operating system and are not supported by the Certbot team!

Maybe we should just use the Ubuntu packages? How old Ubuntu do we need to support?

Or use certbot-auto: https://certbot.eff.org/#pip-other

vkurup commented 7 years ago

Ubuntu 12.04 will be out-of-support in 2 months, which means I think we should focus on supporting 14.04+. That said, I think I'd prefer to go with using certbot-auto rather than the Ubuntu package. The Ubuntu package is only available on 16.04, and per their docs is out-of-date.

Also, the Ubuntu package and binaries are currently labelled letsencrypt which means we'd need to support slightly different installation and execution commands if we wanted to use the Ubuntu package for 16.04+ and certbot-auto for <16.04.