search

caktus / tequila-common

Ansible role for setting up users, keys, directories, and a firewall for a Django server
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

DJAN-107 tequila adoption #1

Closed jbradberry closed 7 years ago

jbradberry commented 8 years ago

Merging together the old common and structure roles, and splitting off into its own repo, to support installation using ansible-galaxy.

dpoirier commented 8 years ago

Here and elsewhere, I'm wondering when we have more than a couple tasks in a row that only run when the same condition is true, if it'd be clearer if we moved those tasks to another file and used a conditional include instead of having them all in main?

jbradberry commented 8 years ago

Hm, intriguing. Yes, I think I might like that. (The conditional includes, that is.)

dpoirier commented 8 years ago

Or we could use the new block feature in Ansible 2.0 if we're willing to require Ansible 2.0. (Which wouldn't bother me at all.)

jbradberry commented 8 years ago

I went with the conditional include, for now.

dpoirier commented 8 years ago

We need to do an "apt-get update" before trying to install any packages.

dpoirier commented 8 years ago

Can we add something like this as the first task, to prevent a bad configuration from locking everyone out of the deployed systems?

- name: make sure we've defined some dev users
  fail: msg="Please define one or more developers in the `users` variable"
  when: users|length == 0
jbradberry commented 8 years ago

@poirier r? I believe I've addressed all of your review comments.

dpoirier commented 7 years ago

:shipit: I haven't tried it, but I assume you have and it looks reasonable.

dpoirier commented 7 years ago

P.S. at work I'm @dpoirier. The poirier ID is my personal account.