cal-adapt / climakitae

A Python toolkit for retrieving, visualizing, and performing scientific analyses with data from the Cal-Adapt Analytics Engine.
https://climakitae.readthedocs.io
BSD 3-Clause "New" or "Revised" License
19 stars 2 forks source link

Daylight Savings adjustment for Timezone correction #325

Closed claalmve closed 6 months ago

claalmve commented 6 months ago

Description of PR

Summary of changes and related issue Modifying converting to local timezone function to account for daylight savings by interpolating for missing times and dropping first instance of repeated times (when daylight savings starts and ends).

Relevant motivation and context We want a 8760 dataframe for locally-correct timezones for TMY, and for other potential use-cases in the future.

Dependencies required for this change? None

Fixes # (issue), delete if not necessary None

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Tested within TMY to ensure that there are no incorrect timestamps after adjusting to local time, but will add tests in back-end soon as well.

Checklist:

claalmve commented 6 months ago

Closing this PR for now, as an alternative quicker-fix will be implemented for TMY notebooks. Converting to local time will be re-addressed in the back-end in the future.