Bug fix on TMY: elevation in export

[vicford]

Description of PR

Summary of changes and related issue Previously, TMY file export was breaking on using an API requests call to the EPQS DEM to obtain elevation. As far as I can tell, this is on the EPQS side of things and not on our code base. To address this, I added the corresponding elevation values from wecc-station csv to the hadisd_stations csv file that is used in the climakitae backend, and modified the TMY code to obtain the corresponding elevation value when requested. At present, when a custom location is passed, elevation is set to 0. This will be a future fix.

Relevant motivation and context

Dependencies required for this change? N/A

Fixes # (issue), delete if not necessary

Type of change

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. To test, please run the TMY notebook and ensure that both .tmy and .epw files are produced

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works -- N/A
• [ ] New and existing unit tests pass locally with my changes -- N/A
• [x] Any dependent changes have been merged and published in downstream modules

[Tianchi-Liu]

I understand that fix is on the way, but I wonder if it makes sense for TMY to have -9999 elevations when custom locations are passed. Or another value that cannot be mistaken as actual elevation. Just a thought!

[vicford]

I understand that fix is on the way, but I wonder if it makes sense for TMY to have -9999 elevations when custom locations are passed. Or another value that cannot be mistaken as actual elevation. Just a thought!

This is a great point @Tianchi-Liu - the official EPW documentation states the range of acceptable elevation is -1000 to 9999.9, with a default value of 0.0. They don't have a rule for missing value for elevation, and I suspect that if a value is missing in the header file, the analysis program fails to run. I think for the time being it is okay to use the default value as a stop gap, and perhaps incorporate an optional argument with markdown explaining that if a custom location is passed the user must provide the elevation value or it will default to 0

[claalmve]

Ran TMY export and generation looks good to me with the change in deriving elevation. Nice job finding a fix so quickly!