cal-adapt / climakitae

A Python toolkit for retrieving, visualizing, and performing scientific analyses with data from the Cal-Adapt Analytics Engine.
https://climakitae.readthedocs.io
BSD 3-Clause "New" or "Revised" License
19 stars 2 forks source link

Update Read the Docs configuration #374

Closed Tianchi-Liu closed 2 months ago

Tianchi-Liu commented 2 months ago

Description of PR

Summary of changes and related issue

Relevant motivation and context

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Build succeeded. Preview: https://climakitae--374.org.readthedocs.build/en/374/

Checklist:

Tianchi-Liu commented 2 months ago

Is there a reason for having so many packages in the readthedocs requirements? If it is only for setting up virtualenv locally for building files then what I do is first load the requirements.txt from the climakitae package and then load the requirements.txt here in the docs dir.

The packages are for setting up the remote builds as well. I hoped including them all would prevent some build failures due to dependency issues such as those that occurred recently.

Tianchi-Liu commented 2 months ago

@elehmer I reverted the updates, but added ipython to docs/requirements.txt. I also updated the order of req.txt and docs/req.txt installation in .readthedocs.yaml so the main requirements get installed first. Does this look better?

elehmer commented 2 months ago

@elehmer I reverted the updates, but added ipython to docs/requirements.txt. I also updated the order of req.txt and docs/req.txt installation in .readthedocs.yaml so the main requirements get installed first. Does this look better?

Thanks for that as I think just the minimum to get readthedocs working is for the best.

Can you set ipython==8.5.0? That is what it is on the HUB. You can always check the version on the HUB by opening a Terminal and typing conda list | grep <package_of_interest>