cal-adapt / climakitae

A Python toolkit for retrieving, visualizing, and performing scientific analyses with data from the Cal-Adapt Analytics Engine.

https://climakitae.readthedocs.io

BSD 3-Clause "New" or "Revised" License

21 stars 2 forks source link

Adding logic to `drop_invalid_wrf_sims` to account for difference in number of simulations by timescale too #402

Closed claalmve closed 4 months ago

claalmve commented 4 months ago

Description of PR

This PR includes/removes simulations depending on the dataset timescale as well as the resolution, rather than originally just the resolution.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. WL notebooks

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules