cal-adapt / climakitae

A Python toolkit for retrieving, visualizing, and performing scientific analyses with data from the Cal-Adapt Analytics Engine.

https://climakitae.readthedocs.io

BSD 3-Clause "New" or "Revised" License

21 stars 2 forks source link

SCE Pilot- Batch Mode with a Warming Level Approach #403

Closed claalmve closed 3 months ago

claalmve commented 4 months ago

Description of PR

Summary of changes and related issue Integrating a warming level approach with batch mode.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

claalmve commented 3 months ago

get_closest_gridcell is working well with one caveat that, for LOCA, lat lon far from the cached area still outputs data. The issue would be very easy to resolve once crs is defined. In the mean time, consider setting the tolerance to a tiny number in degrees. The change getting the function to no longer error for LOCA is definitely an improvement, so feel free to merge it!

Great catch! The tolerance is basically all of the Earth for LOCA data as is. It's now been fixed to have a tolerance adjusted to LOCA lat/lon rather than WRF x/y.