cal-adapt / climakitae

A Python toolkit for retrieving, visualizing, and performing scientific analyses with data from the Cal-Adapt Analytics Engine.
https://climakitae.readthedocs.io
BSD 3-Clause "New" or "Revised" License
21 stars 2 forks source link

mm/time unit bug #417

Closed nicolejkeeney closed 3 months ago

nicolejkeeney commented 3 months ago

Description of PR

Fix bug in code that was causing an error if you tried to retrieve variables with units of mm/time (Evaporation and Maximum Precipitation)

How To Test

Try retrieving the max precip and evaporation variables in different units. Confirm that you can retrieve the data without error and that the unit conversions look okay :D

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

nicolejkeeney commented 3 months ago

Fix unit bug in Maximum Precipitation

nicolejkeeney commented 3 months ago

Fix unit bug in Maximum Precipitation

nicolejkeeney commented 3 months ago

No problems returning data for either max precip or evaporation!

However noticing that the "default" unit for max precip is "mm/hr" and for evaporation it's "mm/d". I'm guessing the evaporation data native unit is designed as such?

Yep these are just the native units of the data!