search

cal-itp / benefits

Transit benefits enrollment, minus the paperwork.
https://docs.calitp.org/benefits
GNU Affero General Public License v3.0
26 stars 9 forks source link

Chore: update enrollment retry page #2040

Closed thekaveman closed 4 months ago

thekaveman commented 4 months ago

Closes #2031

The /retry page was functioning as both our "user" enrollment error page (i.e. #2031) and our "system" enrollment error page (i.e. #2032).

This PR updates the language so the page is more explicitly for "user" enrollment errors.

2032 will have to make additional changes e.g. by creating a new route/template.

This PR also simplifies the view logic of /retry, to remove the unnecessary blocking of GET requests to that endpoint (which makes testing easier).

Current on top of #2039

Reviewing

  1. Launch the app locally
  2. Verify eligibility for any flow
  3. One verified, visit /enrollment/retry
  4. See the updated copy and design
github-actions[bot] commented 4 months ago

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  benefits/enrollment
  analytics.py
  views.py
Project Total  

This report was generated by python-coverage-comment-action