Fix: model cleanups for the Admin

cal-itp / benefits

Transit benefits enrollment, minus the paperwork.

https://docs.calitp.org/benefits

GNU Affero General Public License v3.0

25 stars 9 forks source link

Fix: model cleanups for the Admin #2078

Closed thekaveman closed 2 months ago

thekaveman commented 2 months ago

Closes #2065

implements the __str__ method on AuthProvider so it gets a human-readable label in the Admin

Closes #2072

removes the override of blank = False from SecretNameField to prevent validation errors in the Admin

github-actions[bot] commented 2 months ago

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
benefits/core
models.py
Project Total

This report was generated by python-coverage-comment-action

thekaveman commented 2 months ago

Confirming on dev:

AuthProvider has friendlier names now (sort of):

EligibilityVerifier.api_auth_key_secret_name can now be blank:

thekaveman commented 2 months ago

I might open a follow up ticket to add a label field to the AuthProvider since the client names can be the same, and that doesn't really say as much. Anyway, better than Auth provider (0) for now.