Closed thekaveman closed 1 month ago
The workflow is added as a required check to merge PRs
Need to configure this once it is available in Settings
I added this as a required check for dev
, test
, and prod
.
I forgot, if we have a required check that only runs sometimes (e.g. because of a path filter on the PR files) then that check will block some PRs.
I think to simplify we can just remove the path filter in the workflow. This check shouldn't take very long comparatively.
Sometimes we make model changes and forget to generate a new migration, e.g. with the case of #2078 and the follow-up #2086.
Let's create a PR check that runs the
bin/makemigrations.sh
script and errors if there are pending migrations.When a migration is needed, the output looks like:
When there are no pending migrations, the output looks like:
Acceptance Criteria
benefits/
directorybin/makemigrations.sh
No changes detected
, the workflow fails