Feat: check makemessages

cal-itp / benefits

Transit benefits enrollment, minus the paperwork.

https://docs.calitp.org/benefits

GNU Affero General Public License v3.0

27 stars 9 forks source link

Feat: check makemessages #2155

Closed angela-tran closed 3 months ago

angela-tran commented 3 months ago

Similar to #2122, this PR adds a workflow to check that the Django message files are up-to-date.

Rather than making a new workflow, I added a step to the existing check-makemigrations workflow so that the two steps can use the same runner that has already checked out the repo, installed system packages, installed Python packages, etc. and to minimize the amount time it takes to check migrations and messages. (See https://github.com/cal-itp/benefits/issues/2092#issuecomment-2146300444 for more context on required checks.)

github-actions[bot] commented 3 months ago

Coverage report

This PR does not seem to contain any modification to coverable code.

angela-tran commented 3 months ago

Nice, makes sense to combine into a single check.

You'll need to update the branch protection in order to merge this PR, since the check-makemigrations check was renamed by this PR and won't ever run.

Thanks! I updated the branch protection for dev, test, and prod.