Feat: enrollments can expire

cal-itp / benefits

Transit benefits enrollment, minus the paperwork.

https://docs.calitp.org/benefits

GNU Affero General Public License v3.0

25 stars 9 forks source link

Feat: enrollments can expire #2165

Closed angela-tran closed 2 weeks ago

angela-tran commented 3 weeks ago

Closes #2062

This PR reverts "Revert "Feat: enrollments can expire (#1989)" (#2052)".

There were merge conflicts with various features and refactors that were done since #2052, and I think I resolved them all correctly. (Examples are system enrollment error logic and enrollment success template refactor.)

github-actions[bot] commented 3 weeks ago

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
benefits
settings.py
benefits/enrollment
views.py
Project Total

This report was generated by python-coverage-comment-action

angela-tran commented 2 weeks ago

I manually tested the expiration scenarios in enrollment:index using the MST Courtesy Card group in QA. With the fix from cal-itp/littlepay#64, they work for me.

https://github.com/cal-itp/benefits/blob/2a80a60e62022fcd53d8cb802ed2258deafc8bd3/benefits/enrollment/views.py#L117-L155

angela-tran commented 2 weeks ago

Rebased on top of latest dev