cal-itp / benefits

Transit benefits enrollment, minus the paperwork.
https://docs.calitp.org/benefits
GNU Affero General Public License v3.0
28 stars 9 forks source link

[TRACKING] reCAPTCHA and related design changes #2537

Open machikoyasuda opened 9 hours ago

machikoyasuda commented 9 hours ago

This is the design ticket: https://github.com/cal-itp/benefits/issues/2494

Recommended order of dev tickets:

All these tickets should be completed before a deploy.

The one open question: Whether the Ageny card form page needs the text. I'm leaning towards no, but need 100% confirmation from @indexing

machikoyasuda commented 8 hours ago

@thekaveman @angela-tran @lalver1

I ended up making tickets for the realignment of each page, as it requires changing every individual template for every flow (rather than say, being able to easily change all of this in 1 base template file or 1 CSS change), and I wanted to make smaller PRs that are focused and easier to QA. Aside from the last ticket (text realignment 24px/72px), all the tickets can be done synchronously by the whole team - since there aren't depenencies and they're on different files. I imagine most of these PRs will involve deleting CSS and making a small CSS class change (like from col-lg-8 to col-lg-6).

If finishing all of these tickets then reveals to us that greater refactors can be made to template files or CSS (which I do anticipate!), I think that should be a new ticket for the future, and should be discussed when the whole reCAPTCHA removal project is complete. The focus of these tickets is to get the app in a clean deployable state.

indexing commented 8 hours ago

@machikoyasuda Response to your question in the description here: https://github.com/cal-itp/benefits/issues/2494.

TL;DR Let's add the informational copy everywhere we use reCaptcha.