cal-itp / calitp.org

A brief explainer website for the California Integrated Travel Project (Cal-ITP).
https://www.calitp.org
GNU Affero General Public License v3.0
2 stars 3 forks source link

Home: Small fixes #361

Closed machikoyasuda closed 3 months ago

machikoyasuda commented 3 months ago

closes #352

netlify[bot] commented 3 months ago

Deploy Preview for cal-itp-website ready!

Name Link
Latest commit 2e92185462ee54bb71aadcc6fe7bf9674e88ede6
Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/6696aaee47548e00082b9e2f
Deploy Preview https://deploy-preview-361--cal-itp-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ohmegasquared commented 3 months ago

Links look great! No more drop shadow looks good.

Was updating the images the dot images?

  1. the first dots are flipped horizontally

    Screenshot 2024-07-16 at 12 09 59 PM
  2. above our initiatives should be the straight line of dots

    Screenshot 2024-07-16 at 12 13 39 PM
  3. the blue card backgrounds on the CTAs look good. Can you re-export the images, the stroke was updated to primary dark blue. And are these cards 4 columns? they feel a little tight.

(Probably a diff PR but wanted to call out -- I also removed "our" from the link for Press Page so it reads a bit easier)

machikoyasuda commented 3 months ago

@ohmegasquared

6-columns centered

image

8-columns centered (with the image in its own separate column)

image

I just noticed on Figma though... the Initatives section text is 6 columns, not 8. Should I change it (I can do it in a separate PR)?

image
ohmegasquared commented 3 months ago

I think the spacing for the initiatives looks good!

In figma, the bringing industry standards and goals section looks wider with 6 columns than netlify, do we have strong margins/padding for that section? the container appears to be smaller

the second divider seems to be a little streched? the circles look ovals to me (not sure if it is the old 2023 divider and just need to pull the new image?)

Screenshot 2024-07-22 at 11 25 01 AM

The hero section should spread 9 columns