search

cal-itp / calitp.org

A brief explainer website for the California Integrated Travel Project (Cal-ITP).
https://www.calitp.org
GNU Affero General Public License v3.0
2 stars 3 forks source link

Partners #364

Closed machikoyasuda closed 3 months ago

machikoyasuda commented 3 months ago

closes #351

What this PR does

Notes

netlify[bot] commented 3 months ago

Deploy Preview for cal-itp-website ready!

Name Link
Latest commit 49e25db7dc6b829cc73b50b1f3a4e5826c5415be
Latest deploy log https://app.netlify.com/sites/cal-itp-website/deploys/669f063632fa6900084f7a03
Deploy Preview https://deploy-preview-364--cal-itp-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

machikoyasuda commented 3 months ago

This PR is ready for a code review. The copy is not finalized yet, so I have just used the latest available copy. When the code and the latest copy is available, then this PR can be approved and deployed to a separate Netlify preview page so that the partners can review it easily.

I also filed #365 this because I noticed the blues are different. It is not part of this PR though, as it should be treated separately.

cc @thekaveman @mrose914 @ohmegasquared

mrose914 commented 3 months ago

This is looking great, thank you!

CDT messaged today that they are confirming stats as we speak, but that the other copy is GTG.

CARB messaged last week that they are working on getting a quote + we are confirming CARB funding details that may require add'l disclosures.

I will follow up end of this week or early next to nudge them toward finalizing but we seem to be on track! 🙏

thekaveman commented 3 months ago

I'm starting this new thing of having a basic naming convention for images: (name of page)-(type of image)-(slug), like home-logo-calsta or partners-background-cdt.

:100: :100: :100:

ohmegasquared commented 3 months ago

should we add mobile/web in the image name convention?

thekaveman commented 3 months ago

@machikoyasuda could you please rebase this PR on main to get the other homepage changes in here, so we can see the final final designs with Partners?

machikoyasuda commented 3 months ago

@thekaveman Rebased and updated partner logos to use the latest (have been updated to have all the same height).

machikoyasuda commented 3 months ago

🚧 🚧 🚧 FYI - This pull request is not going to Production. We are still waiting on final copy and approvals.

The "reviews" at this stage for this PR are purely for the design from @ohmegasquared and code from @thekaveman.

🚧 🚧 🚧

machikoyasuda commented 3 months ago

Planning to push up a cleaned up version of this PR after the smaller PRs are merged into main.