Customer stories & Partners: New pages and homepage updates

machikoyasuda commented 3 months ago

closes #351 closes #354 closes #356 closes #382 closes #391 closes #398 closes #403

What this PR does

Partners page
Customer stories page
Homepage update

Plan for PR

[x] Gillian approval 9/9
[x] CalSTA approval

How to review this PR

[x] Run a11y tests on all new pages and homepage
[x] Check copy

Test

This preview link has all the new updates: https://deploy-preview-377--cal-itp-website.netlify.app/ https://deploy-preview-377--cal-itp-website.netlify.app/customer-stories https://deploy-preview-377--cal-itp-website.netlify.app/partners

netlify[bot] commented 3 months ago

Deploy Preview for cal-itp-website ready!

Name	Link
Latest commit	1c4e4d2272a3c1f91e8e34d48913bed8ce5426c0
Latest deploy log	https://app.netlify.com/sites/cal-itp-website/deploys/66d7f0223b67960008638139
Deploy Preview	https://deploy-preview-377--cal-itp-website.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

machikoyasuda commented 3 months ago

@ohmegasquared This is ready for a Design review:

https://deploy-preview-377--cal-itp-website.netlify.app/ - home page logos and new copy https://deploy-preview-377--cal-itp-website.netlify.app/partners - new page

ohmegasquared commented 3 months ago

on the home page, I expected the logos to be in the same column width container as the text above

seeing in netlify going outside of that

on mobile they seem to go off screen

Partners looks great!

machikoyasuda commented 3 months ago

@ohmegasquared Ohhhh good catch - thank you! Firefox renders the homepage differently than Chrome and Safari! 🫨

machikoyasuda commented 3 months ago

Ready for re-review @ohmegasquared

on the home page, I expected the logos to be in the same column width container as the text above

Fixed and confirmed in Firefox, Safari, Chrome:

machikoyasuda commented 3 months ago

This PR is now ready for a preliminary PR review for code (@thekaveman @angela-tran or @lalver1) and design (@ohmegasquared). What I want is a comment here that the Partners section is "Approved for design" or "Approved for code." That will give me the permission to stop working on Partners code/design. You do not need to click the GitHub pull request "Approve" button. That will happen after the copy is in and approved as well.

What I plan to do:

Monday/Tuesday: Get the Partners PR preliminary approval (code and design).
Tuesday/Wednesday: Then, get the Customer Stories PR into this Partners PR preliminary approval (code and design). Once Customer Stories is approved, I'm going to merge Customer Stories into the Partners PR.
Wednesday: After the preliminary approvals are done, I don't want to change any code or design. We are code complete. Only copy changes at this point.
Wednesday/Thursday: At this point, there will only be 1 PR to manage. In this ONE PR, I'll make all copy/photo changes. Send test URL to @mrose914
After that: @mrose914 to communicate final approval to @machikoyasuda, @mrose914 / @thekaveman + one developer approves the PR for reals, then the PR can finally be merged into main and be deployed to prod.

Other notes:

Any changes to the current home page, the current home page's Contact section - need to be created as bug tickets. These bug tickets can be worked on separately, and get approved and merged into production immediately.

ohmegasquared commented 3 months ago

Marissa and I reviewed mobile and web- looks good to us! will make 2 follow up tickets for home dots spacing + footnote adjustment

lalver1 commented 3 months ago

This looks great! I viewed the pages locally on Firefox and Safari and I'd say it's approved for code.

machikoyasuda commented 3 months ago

Fix for #382 applied in this PR

@ohmegasquared

ohmegasquared commented 3 months ago

Design is approved on mobile and web! 🔥

machikoyasuda commented 3 months ago

New combined PR is here 🎊 🎊

This preview link has all the new updates: https://deploy-preview-377--cal-itp-website.netlify.app/ https://deploy-preview-377--cal-itp-website.netlify.app/customer-stories https://deploy-preview-377--cal-itp-website.netlify.app/partners

machikoyasuda commented 3 months ago

Update as of Thursday, Aug 1st, 1PM:

All copy (including alt tags for images/map on Customer Stories) we have is now in the code.
All pages passing WCAG AA.

Open items:

CARB quote (for now it's a placeholder)
MST approval on content and photo
Glenn County updated photo
Link to Metabase Dash for Transit Data Quality Dashboard - on the Home page (https://deploy-preview-377--cal-itp-website.netlify.app/#fn:3) and Partners page (https://deploy-preview-377--cal-itp-website.netlify.app/customer-stories#fn:2) - the link is not in there yet b/c the link goes to a page that is inaccessible to non-logged in users

@mrose914 @thekaveman

machikoyasuda commented 2 months ago

Lots of small fixes in:

Fix link styles for the Our impact section and Benefits Monthly Update link
Fix footnote numbering error
Add a period in footnote style

mrose914 commented 2 months ago

@machikoyasuda I am now connected to our new reviewer at CalSTA. Given that she doesn't have the context Marty did/was prepped with, I'd like to follow up with a couple more edits so I can tell her this is 100% ready for her review. See below:

PARTNERS PAGE

UPDATE CARB QUOTE

[x] “In order to unlock the greenhouse gas reductions and mobility justice opportunities that transit provides, we have to make it easier for people to use California’s buses and trains. Cal-ITP tackles basic but essential challenges that transit users face so that more Californians can make the switch to sustainable transportation options.” Lisa Macumber, chief of CARB’s Equitable Mobility Incentives branch

CUSTOMER STORIES PAGE

[x] Footnote 1 for for daily transit rides in CA >> https://www.transit.dot.gov/ntd/data-product/2022-annual-database-agency-mode-service
[x] Fleet size for MST should be 170
[x] Update 3rd paragraph in MST Customer Story to the following:

In 2022, MST became the first transit agency in the nation to provide an automated method for older adults to obtain their transit benefit via an open-loop contactless payment system. In the past year, there has been a 200% increase in reduced-fare transactions using the contactless system!

Could you push these to staging today? Once that is done, we will wait for anything she requests we change (I'm going to strongly push for just an approval on what is here) and then we will be GTG. Thank you!

cc @ohmegasquared and @o-ram (pls let us know if MST provided an updated photo)

mrose914 commented 2 months ago

I am adding final copy changes here, will confirm via comment once they are all in:

In Ditto:

machikoyasuda commented 1 month ago

@ohmegasquared @mrose914 The photo ticket (#403) and the above Ditto fixes are made: https://deploy-preview-377--cal-itp-website.netlify.app/

mrose914 commented 1 month ago

Thank you! Awaiting the 👍 from Gillian. I may have one more sentence to add to the homepage based on her reply.

cal-itp / calitp.org