As a GTFS producer, if I include feed_start_date and feed_end_date in feed_info.txt, I expect those to be respected when consumers interpret service dates in calendar.txt and calendar_dates.txt.
As a data analyst or GTFS assessments team member, I want to trust that the service listed in the warehouse is an accurate representation of what the producer intended.
Currently, in the Cal-ITP GTFS schedule data pipeline service dates are assessed without any reference to feed_info.txt.
Acceptance Criteria
[ ] gtfs_schedule_stg_daily_service includes logic that only makes service determinations for dates where feed_start_date <= service_date <= feed_end_date for feeds where feed_info is present
[ ] check for any other tables that need similar changes
Notes
This would make most sense to do as part of a type 2 refactor that keys everything off of feed version. These assessments need to be made at the feed level.
Sprint Ready Checklist
[ ] Acceptance criteria defined
[ ] Team understands acceptance criteria
[ ] Team has defined solution / steps to satisfy acceptance criteria
I think this is still something to consider doing. The handling of feed_timezone in #2457 could provide an example of how to pull some values from certain files and apply them feed-wide.
User stories
As a GTFS producer, if I include
feed_start_date
andfeed_end_date
infeed_info.txt
, I expect those to be respected when consumers interpret service dates incalendar.txt
andcalendar_dates.txt
.As a data analyst or GTFS assessments team member, I want to trust that the service listed in the warehouse is an accurate representation of what the producer intended.
Currently, in the Cal-ITP GTFS schedule data pipeline service dates are assessed without any reference to
feed_info.txt
.Acceptance Criteria
gtfs_schedule_stg_daily_service
includes logic that only makes service determinations for dates wherefeed_start_date <= service_date <= feed_end_date
for feeds wherefeed_info
is presentNotes
This would make most sense to do as part of a type 2 refactor that keys everything off of feed version. These assessments need to be made at the feed level.
Sprint Ready Checklist