Closed lauriemerrell closed 1 year ago
Investigated this further today as we actually violated our 99% success threshold; it turns out that Python's ZipFile does NOT treat __MACOSX
as a directory, so we were only alerting when there was another directory in addition to the __MAXOSX
"directory". See https://gtfs.calitp.org/production/GuadalupeFlyerParatransitFlex.zip as an example of success and https://gtfs.calitp.org/production/HumboldtTransitAuthorityDialARideFlex.zip as an example of failure. I'm going to add special handling for __MAXOSX
so we exclude it from our definition of validity, as well as start reporting all unzip errors to Sentry.
The query:
Returns a bunch of hidden files that were in
__MACOSX
directories but whereunzip_success=true
. In some sense this is desirable behavior (I don't think we want to fail parsing for hidden files), but I thought that the unzip job should fail for any directories identified; the problem is that the__MACOSX
directory doesn't seem to be registering as a directory (I believe that in the unzip outcomes file, these have no zipfile directories found).Purpose of this ticket is to define the task of just looking this and figuring out:
MACOSX
directories being flagged as directories