Refactor: move the application directory up a level

cal-itp / eligibility-server

Server implementation of the Eligibility Verification API

https://docs.calitp.org/eligibility-server

GNU Affero General Public License v3.0

3 stars 3 forks source link

Refactor: move the application directory up a level #463

Closed thekaveman closed 2 months ago

thekaveman commented 3 months ago

Related to:

This PR should be merged after the one in docker-python-web.

This PR also removes the explicit WORKDIR setting in the appcontainer Dockerfile, as the base image already sets the default we want.

github-actions[bot] commented 3 months ago

Coverage report

This PR does not seem to contain any modification to coverable code.

thekaveman commented 2 months ago

@lalver1:

The only thing I saw is that in the compose file of benefits we use ./:/calitp/app for the volume mount and here we use .:/calitp/app/. They are both equivalent so it doesn't matter but if we wanted to make them the same we could.

Thanks for that feedback, I fixed the mounts to be the same as in benefits and rebased.