cal-itp / mobility-marketplace

A one-stop resource for modern, equitable and accessible public transit products and services.
https://www.camobilitymarketplace.org/
GNU Affero General Public License v3.0
5 stars 1 forks source link

For vendors: Add to nav #508

Closed machikoyasuda closed 9 months ago

machikoyasuda commented 9 months ago

closes #500

What this PR does

machikoyasuda commented 9 months ago

@thekaveman @angela-tran This is ready for review. Since we're going to be going live when all the PRs are in, this PR can be safely merged into the 499-for-vendors-newsletter branch.

angela-tran commented 9 months ago

@machikoyasuda Do the design changes from https://github.com/cal-itp/mobility-marketplace/issues/500#issuecomment-1832186529 belong in this PR?

angela-tran commented 9 months ago

We currently don't get a preview site if the target branch is not main. A workaround for devs is to run the branch locally

machikoyasuda commented 9 months ago

@angela-tran No

machikoyasuda commented 9 months ago

@angela-tran the notes in that comment aren't actually changing anything / aren't actually reflected on Figma accurately:

And having a hard-coded 72px number between links doesn't really make sense in a responsive web world.

So until we have the Header's link styles, #501 and #502, we can't really change the nav.

cc @segacy1